(maint) Fix Rubocop #203
Merged
(maint) Fix Rubocop #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the rubocop rules have changed names or are now redundant. This commit updates the rubocop.yml to be correct for rubocop v0.57.2
Rubocop only expects CRLF line endings on Windows, however this project is LF. This commit enforces LF as the line-ending no matter what OS.
This commit fixes most of the simple rubocop violations (indentation, whitespace arrays of symbols) and adds a Rubocop TODO file for the remainder. Later commits will fix the TODO items and the file can be removed.
|
Visual inspect shows no files have changed CRLF <-> LF |
Good for merge |
scotje
approved these changes
Jun 19, 2019
There was a problem hiding this comment.
Thanks @glennsarti, I had started on this yesterday but got derailed onto other things.
I pushed a couple more commits to make the bundler environment more repeatable (mine was trying to use rubocop 0.71 and so failing again) and also ensure the rake rubocop task will actually fail in Travis when there are issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the rubocop rules have changed names or are now redundant. This commit
updates the rubocop.yml to be correct for rubocop v0.57.2
Rubocop only expects CRLF line endings on Windows, however this project is LF.
This commit enforces LF as the line-ending no matter what OS.
This commit fixes most of the simple rubocop violations (indentation, whitespace
arrays of symbols) and adds a Rubocop TODO file for the remainder. Later
commits will fix the TODO items and the file can be removed.